Skip to content

vSphere: Set default disktype to thick not eager#5395

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_set_default_to_thick
Nov 19, 2021
Merged

vSphere: Set default disktype to thick not eager#5395
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_set_default_to_thick

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

@jcpowermac jcpowermac commented Nov 17, 2021

In #4664 I incorrectly commented to use eagerZeroedThick.
The correct disktype to keep the vSphere install the same
as previous versions is thick. eagerZeroed as named
will write zeros when creating the vmdk which significantly
extends the time to import and clone virtual machines.

@jcpowermac
vSphere: Set default disktype to thick not eager
d56ecb5 
In openshift#4664 I incorrectly commented to use `eagerZeroedThick`.
The correct disktype to keep the vSphere install the same
as previous versions is `thick`. eagerZeroed as named
will write zeros when creating the vmdk which significantly
extends the time to import and clone virtual machines.
@openshift-ci openshift-ci Bot requested review from jhixson74 and rna-afk November 17, 2021 14:32
@rna-afk
Copy link
Copy Markdown
Contributor

rna-afk commented Nov 17, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@staebler
Copy link
Copy Markdown
Contributor

staebler commented Nov 18, 2021

@jcpowermac As a follow-up, can you do the following, which should have been done as part of #4664 as well?

  1. Add a kubebuilder:validation:Enum annotation to the DiskType type.
  2. Add documentation to the DiskType field making it explicit what the default value is.
  3. Add code to the SetPlatformDefaults to set the default value when the user omits it.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Nov 18, 2021

@jcpowermac As a follow-up, can you do the following, which should have been done as part of #4664 as well?

  1. Add a kubebuilder:validation:Enum annotation to the DiskType type.
  2. Add documentation to the DiskType field making it explicit what the default value is.
  3. Add code to the SetPlatformDefaults to set the default value when the user omits it.

/approve

Thanks @staebler

@ayesha54 is this something you would want to take as an action?

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ayesha54
Copy link
Copy Markdown
Contributor

ayesha54 commented Nov 18, 2021

@jcpowermac As a follow-up, can you do the following, which should have been done as part of #4664 as well?

  1. Add a kubebuilder:validation:Enum annotation to the DiskType type.
  2. Add documentation to the DiskType field making it explicit what the default value is.
  3. Add code to the SetPlatformDefaults to set the default value when the user omits it.

/approve

Thanks @staebler

@ayesha54 is this something you would want to take as an action?

yes sure

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 18, 2021 •
edited
Loading

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr d56ecb5 link false /test e2e-openstack-kuryr
ci/prow/e2e-openstack d56ecb5 link false /test e2e-openstack
ci/prow/e2e-metal-ipi-ovn-ipv6 d56ecb5 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-workers-rhel7 d56ecb5 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-crc d56ecb5 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c6c1910 into openshift:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@rna-afk rna-afk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jcpowermac @rna-afk @staebler @openshift-bot @ayesha54 @openshift-merge-robot